Various audit fixes - Githubissues

yondonfu commented 4 years ago

This PR implements a few fixes related to the external security audit.

Summary of changes:

Make getTicketHash() public so that off-chain hashing implementations can be more easily checked against the output from the EVM
Add a gas report test for redeeming winning tickets
Use Node v10.17.0 and upgrade a few dependencies
Add some notes in the README about ABIEncoderV2 usage and ERC20 functions
Add comments about calling setters for upgradeable contracts as well as shadowed functions in ManagerProxy
Add an integration test demonstrating that honest transcoders are protected against ticket front running scenarios as long as they don't hold on to more value than their reserve allocation

See the commit log for more details.

kyriediculous commented 4 years ago

I assume 6aebc09 - use node v10.7.0 is actually using v10.17.0 as that is the latest release for v10.x. ? Could we fix up the commit message if that's the case?

Edit: Oh it is 10.7.0 , any particular reason for this release instead of the latest v10.17.0?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1266

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 1215:	0.0%
Covered Lines:	686
Relevant Lines:	686

💛 - Coveralls

yondonfu commented 4 years ago

Oh it is 10.7.0 , any particular reason for this release instead of the latest v10.17.0

For some reason I thought that there was a dependency problem with v10.17.0, but I just tried again and there does not seem to be any problems...Rebased and replaced the commit with one that uses Node v10.17.0

yondonfu commented 4 years ago

Rebased

kyriediculous commented 4 years ago

Good to go once checks pass ! 🏁

livepeer / protocol

Various audit fixes #362

Pull Request Test Coverage Report for Build 1266

💛 - Coveralls