livepeer / protocol

Livepeer protocol
MIT License
152 stars 45 forks source link

LIP-52: claimEarnings snapshot #397

Closed kyriediculous closed 4 years ago

kyriediculous commented 4 years ago

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required) Added unit tests and integration tests

Does this pull request close any open issues? https://github.com/livepeer/LIPs/blob/master/LIPs/LIP-52.md

Checklist:

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 432d1786-962c-4ddd-a3b3-cdee4e2458ec


Totals Coverage Status
Change from base Build d5bdd4ff-6f3b-48b0-b9a9-766cc685537d: 0.09%
Covered Lines: 780
Relevant Lines: 780

💛 - Coveralls
kyriediculous commented 4 years ago

5d171f1 moves the logic from the modifiers into internal functions to reduce the bytecode length.

Force-pushed to rebase on top of LIP-36

yondonfu commented 4 years ago

Changed the base branch to streamflow since the LIP-36 branch has already been merged there.

@kyriediculous Can you resolve the conflicts and rebase to squash the fixup commits on this branch? PR looks ready to merge after that.

yondonfu commented 4 years ago

Just FYI looks like a few of the changes in fixup commits were dropped during the rebase. Examples: