Closed kyriediculous closed 4 years ago
Totals | |
---|---|
Change from base Build d5bdd4ff-6f3b-48b0-b9a9-766cc685537d: | 0.09% |
Covered Lines: | 780 |
Relevant Lines: | 780 |
5d171f1 moves the logic from the modifiers into internal functions to reduce the bytecode length.
Force-pushed to rebase on top of LIP-36
Changed the base branch to streamflow
since the LIP-36 branch has already been merged there.
@kyriediculous Can you resolve the conflicts and rebase to squash the fixup commits on this branch? PR looks ready to merge after that.
Just FYI looks like a few of the changes in fixup commits were dropped during the rebase. Examples:
What does this pull request do? Explain your changes. (required)
Specific updates (required)
MerkleSnapshot
contractMerkleSnapshot
contractclaimSnapshotEarnings
method toBondingManager
claimSnapshotEarnings
unit testsethereumjs-util
library dependency from5.1.2
to6.0.0
and resolve incompatibilitiesMerkleTree
JS class based on // https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/test/helpers/merkleTree.jsHow did you test each of these updates (required) Added unit tests and integration tests
Does this pull request close any open issues? https://github.com/livepeer/LIPs/blob/master/LIPs/LIP-52.md
Checklist:
npm run test
pass