What does this pull request do? Explain your changes. (required)
Completes test/integration/Earnings.js with post LIP-36 cases
Specific updates (required)
Changed acceptable delta from 0.001 to 0.01
Alternatives
Keep acceptable delta in the tests at 0.001 but change the MathUtils.sol , PERC_DIVISOR to 1*10^9
This affects other contracts that use MathUtils though
How did you test each of these updates (required)
Ran tests
Added console log statements to cumulativeEarningsAndCheck function to see that the delta doesn't exceed the maximum I anticipated (0.005)
What does this pull request do? Explain your changes. (required) Completes
test/integration/Earnings.js
with post LIP-36 casesSpecific updates (required)
Alternatives Keep acceptable delta in the tests at 0.001 but change the
MathUtils.sol
,PERC_DIVISOR
to1*10^9
This affects other contracts that useMathUtils
thoughHow did you test each of these updates (required) Ran tests
Added console log statements to
cumulativeEarningsAndCheck
function to see that the delta doesn't exceed the maximum I anticipated (0.005)Does this pull request close any open issues?