Hardhat refactor 👷 - Githubissues

livepeer / protocol

Livepeer protocol

MIT License

154 stars 45 forks source link

Hardhat refactor 👷 #434

Closed kyriediculous closed 3 years ago

kyriediculous commented 3 years ago

What does this pull request do? Explain your changes. (required) Hardhat refactor 👷

Specific updates (required)

general

Added hardhat-deploy plugin
Create custom contract deployer using hardhat-deploy so it works with out proxies
Set allowJs: true in tsconfig
Switch to hardhat-web3
Use ES6 import instead of require for module imports
Fix test running
Deployment script for polls https://github.com/livepeer/protocol/pull/435
Cleanup dependencies, remove other legacy truffle related scripts https://github.com/livepeer/protocol/pull/444
Use hardhat-abi-exporter plugin , this exports all contract ABIs into an /abi folder
Fix ESlint for both .js and .ts files https://github.com/livepeer/protocol/pull/445

unit tests

Fix controller unit tests https://github.com/livepeer/protocol/pull/421
Fix governor unit tests https://github.com/livepeer/protocol/pull/422
Fix faucet unit tests https://github.com/livepeer/protocol/pull/423
Fix ManagerProxy unit tests https://github.com/livepeer/protocol/pull/424
Fix MerkleSNapshots unit tests https://github.com/livepeer/protocol/pull/425
Fix Poll, Poll creator unit tests https://github.com/livepeer/protocol/pull/426
Fix ServiceRegistry unit tests https://github.com/livepeer/protocol/pull/426
Fix VariableSupplyToken unit tests https://github.com/livepeer/protocol/pull/426
Fix BondingManager unit tests https://github.com/livepeer/protocol/pull/427
Fix RoundsManager unit test https://github.com/livepeer/protocol/pull/430
Fix solidity unit tests https://github.com/livepeer/protocol/pull/436

integration tests

Fix TicketBroker integration tests https://github.com/livepeer/protocol/pull/428
Fix Minter integration tests https://github.com/livepeer/protocol/pull/429
Fix Delegation integration test https://github.com/livepeer/protocol/pull/432
Fix gas-reports and remaining integration tests https://github.com/livepeer/protocol/pull/433

How did you test each of these updates (required) Ran test suite

Does this pull request close any open issues? Fixes #416 Fixes #417 Fixes #441

Checklist:

[x] README and other documentation updated
[x] All tests using npm run test pass

kyriediculous commented 3 years ago

Yeah there is a failing test indeed, not an assertion but a timing issue due to an afterEach hook and an async function call. They are passing from time to time however so it seems to be related to a timing issue. We're still investigating this. As you can see CI passed as the latest PRs were merged.

This also seems to be specific to running with coverage, when running without coverage these tests pass just fine (at least from my experience so far).