search

livepeer / protocol

Livepeer protocol
MIT License
154 stars 45 forks source link

Move CI to github actions #439

Closed kyriediculous closed 3 years ago

kyriediculous commented 3 years ago

What does this pull request do? Explain your changes. (required) Use github actions for CI and fix coveralls run

Checklist:

yondonfu commented 3 years ago

The CircleCI build is still being triggered even though the config file is removed because this repo is still configured to send a request to a CircleCI webhook for PRs which then causes CircleCI to complain about a missing config file when the build is started. We can remove the webhook from the repo, but that would also disable CircleCI builds for the streamflow branch.

Since we're not merging the next branch into the streamflow branch for awhile and in order to support CI builds on streamflow if anything needs to be merged there before the next branch is merged in, let's set the target branch for this PR to streamflow so we can continue to support CI builds there with GH actions. Then, the next branch can just include the relevant commits with the GH action build as well.

After the GH action build + test is passing here we can remove the CircleCI webhook from the repo to get rid of the failing CircleCI build.

yondonfu commented 3 years ago

We should be able to remove the CircleCI config file right? It's ok if CircleCI still fails due to the missing config file since we'll disable it after this PR is merged anyway as long as the GH action passes.

kyriediculous commented 3 years ago

Removed circleCI config

yondonfu commented 3 years ago

Looks like the Coveralls step of the GH action is failing with:

Using lcov file: ./coverage/lcov.info
Error:  "2021-08-11T00:33:49.819Z"  'error from getOptions'
Error: Error: Command failed: git cat-file -p a807a1a3983eb6dd6c1fa0f07c5c5da90af36095
fatal: Not a valid object name a807a1a3983eb6dd6c1fa0f07c5c5da90af36095
kyriediculous commented 3 years ago

Are we going to remove circleCI before merging this ?

yondonfu commented 3 years ago

Are we going to remove circleCI before merging this ?

The CircleCI webhook has already been removed for this repo so future builds shouldn't trigger anything on CircleCI's end.