Closed kautukkundan closed 3 years ago
Totals | |
---|---|
Change from base Build 1137227852: | 0.0% |
Covered Lines: | 851 |
Relevant Lines: | 865 |
RE the dependency issue this looks good to me, I think I installed it the wrong way (outdated documentation from a blog rather than the official one) which then persisted itself in the lock file. Not sure why it wasn't caught earlier either, maybe with the move to yarn.
Test update also looks good to me, let's change the base to nv/next
maybe since that has the conflicts resolved with streamflow
and then we can merge nv/next
into next
and then next
into streamflow
. WDYT ?
What does this pull request do? Explain your changes. (required)
The current
solidity-coverage
version overrides the gasPrice during execution and sets it equal to 1. This creates an issue with the EIP-1559 "baseFeePerGas". There is an open issue sc-forks/solidity-coverage/issues/652 to deal with this. This PR includes a temporary and "hacky" solution to overcome the issue by setting theinitialBaseFeePerGas
equal to 0 in the hardhat network config. However, moving forward this should not be the final solution.Specific updates (required)
initialBaseFeePerGas
equal to 0 in the hardhat configHow did you test each of these updates (required)
ran
yarn test:coverage
Does this pull request close any open issues?
closes #447
Checklist:
yarn run test
pass