livepeer / protocol

Livepeer protocol
MIT License
154 stars 45 forks source link

Separated concerns for orchestrator and delegator #477

Closed kautukkundan closed 2 years ago

kautukkundan commented 3 years ago

What does this pull request do? Explain your changes. (required)

Contains API changes which separates functions of orchestrators and delegators. Orchestrator functions include stake, restake, unstake etc whereas delegators can call delegate, undelegate, redelegate etc. This makes the usage of the API more intuitive for the respective users.

splitting /pull/474 into 2 parts

  1. updating stakingManager contracts API
  2. removing bondingManager and rewriting tests

Specific updates (required)

How did you test each of these updates (required)

ran yarn test

Does this pull request close any open issues?

closes #471 #470 #454

Checklist:

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1301164854


Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/bonding/StakingManager.sol 95 102 93.14%
<!-- Total: 95 102 93.14% -->
Files with Coverage Reduction New Missed Lines %
contracts/bonding/StakingManager.sol 1 82.82%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 1295736702: 8.2%
Covered Lines: 1015
Relevant Lines: 1112

💛 - Coveralls