livepeer / protocol

Livepeer protocol
MIT License
154 stars 45 forks source link

polling: Use min stake in PollCreator #520

Closed yondonfu closed 2 years ago

yondonfu commented 2 years ago

What does this pull request do? Explain your changes. (required)

This PR updates the PollCreator to require a minimum stake >= POLL_CREATION_COST from the caller instead of requiring the caller to burn the POLL_CREATION_COST. The caller can meet the minimum stake req with its own stake (i.e. BondingManager.pendingStake()) or its delegated stake (i.e. BondingManager.transcoderTotalStake()).

Since the PollCreator.js unit test was pretty small I updated it to use smock for mocking instead of the GenericMock contract since smock is easier to use for mocking return values.

Specific updates (required)

See commit history.

How did you test each of these updates (required)

Updated unit tests.

Does this pull request close any open issues?

Fixes #508

Checklist: