Closed yondonfu closed 2 years ago
Totals | |
---|---|
Change from base Build 1814506002: | 0.004% |
Covered Lines: | 895 |
Relevant Lines: | 906 |
All commits except for 6086b59 and 13713ba were already merged into confluence
and I recommend just lightly reviewing these commits because these changes were only needed for the L1 BondingManager for testnet and are not applicable for mainnet since we will not be updating the L1 BondingManager on mainnet.
What does this pull request do? Explain your changes. (required)
This PR contains:
Sorry for the big PR! Ended up doing all these things as a part of the Confluence testnet phase 1 deployment on Rinkeby.
We'll likely cherry pick a bunch of these commits into
confluence
as well since they will be helpful for running deployments of the contracts to L2 off that branch.Reviewing this PR should be easier if you review commit by commit and first skip the following commits:
since these two commits change many files.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
yarn test
pass