search

livepeer / protocol

Livepeer protocol
MIT License
152 stars 45 forks source link

BondingManager-fuzzing: added fuzzing campaign against BondingManager transferBond #554

Closed RiccardoBiosas closed 2 years ago

RiccardoBiosas commented 2 years ago

What does this pull request do? Explain your changes. (required) Adds a contract under the foundry/dapptools directory to perform a fuzzing campaign against the BondingManager's transferBond function

Specific updates (required) No relevant updates to the rest of the codebase

How did you test each of these updates (required) Run the new fuzzing tests and the previous test suites to ensure absence of breaking changes

Does this pull request close any open issues? no

Checklist:

kautukkundan commented 2 years ago

WDYT about testing with changing delegates in addition to changing the amount?

yondonfu commented 2 years ago

@RiccardoBiosas Looks like this is approved. Can this be merged?

RiccardoBiosas commented 2 years ago

WDYT about testing with changing delegates in addition to changing the amount?

It's a good idea, but right now adding additional address parameters to the fuzzing test will cause it to freeze indefinitely (might be something related to https://github.com/foundry-rs/foundry/issues/1201). I think it might also help to do a more exhaustive fuzzing campaign in a local e2e setup rather than a live network's fork, so it's something that we can do in a separate issue.