search

livepeer / protocol

Livepeer protocol
MIT License
152 stars 45 forks source link

Add slither to github actions #567

Closed RiccardoBiosas closed 2 years ago

RiccardoBiosas commented 2 years ago

Slither provided some useful plugin to perform static analysis - in particular the upgradeability plugin might be a useful testing tool. However, since static analysis is known to be quite noisy/give a fair amount of false positives, we should decide whether we should just run slither in the testing pipeline for 'awareness' or flag the github action as failed under some circumstances (i.e.: if slither detects X possibly critical issues).

yondonfu commented 2 years ago

in particular the upgradeability plugin might be a useful testing tool.

Related: https://github.com/livepeer/protocol/issues/234

yondonfu commented 2 years ago

Will create a separate issue to track re-enable CodeQL