Replace web3->ethers and JS->TS in RPC class - Githubissues

livepeer / protocol

Livepeer protocol

MIT License

152 stars 45 forks source link

Replace web3->ethers and JS->TS in RPC class #589

Open kautukkundan opened 2 years ago

kautukkundan commented 2 years ago

What does this pull request do? Explain your changes. (required)

Specific updates (required)

convert rpc.js to rpc.ts and introduce types
replace web3.js methods with ethers.js methods
update occurences where RPC class is used to use ethers provider

How did you test each of these updates (required)

Does this pull request close any open issues?

closes #573

Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

RiccardoBiosas commented 2 years ago

Good job starting the refactoring to typescript. I guess we can also improve the type annotations a bit