What does this pull request do? Explain your changes. (required)
This mitigates a couple minor findings from the audit that either haven't been flagged by wardens but we found through self-review (e.g. duplicate checkpoints) or too minor issue to have its own PR (solidity version). Even though I'm combining all the fixes in this PR, each mitigation is done on a separate commit to facilitate review.
Specific updates (required)
Avoid double-checkpointing of transcoders when making self-bonding actions
Add the previous/newLastClaimRound to the DelegatorBondedAmountChanged event (otherwise some changes would be silent on the event side, like unbonding exactly the amount of pending rewards)
The minorest:
Fix solidity version in IBondingVotes.sol file
Add a remappings.txt file to the project, which improves VS Code suggestions and navigation
Fix a few misleading or typod documentations
How did you test each of these updates (required)
Added tests to all the functional changes and yarn test
What does this pull request do? Explain your changes. (required) This mitigates a couple minor findings from the audit that either haven't been flagged by wardens but we found through self-review (e.g. duplicate checkpoints) or too minor issue to have its own PR (solidity version). Even though I'm combining all the fixes in this PR, each mitigation is done on a separate commit to facilitate review.
Specific updates (required)
previous/newLastClaimRoundto theDelegatorBondedAmountChangedevent (otherwise some changes would be silent on the event side, like unbonding exactly the amount of pending rewards)The minorest:
IBondingVotes.solfileremappings.txtfile to the project, which improves VS Code suggestions and navigationHow did you test each of these updates (required) Added tests to all the functional changes and
yarn testWill deploy on devnet after merged.
Does this pull request close any open issues? N/A
Checklist:
yarn testpass