livepeer / protocol

Livepeer protocol
MIT License
154 stars 45 forks source link

test: Get to 100% test coverage #639

Closed victorges closed 6 months ago

victorges commented 6 months ago

What does this pull request do? Explain your changes. (required) This is just to get back to 100% coverage on BondingManager and Manager code by checking an unexercised code path.

Specific updates (required)

How did you test each of these updates (required) yarn test

Does this pull request close any open issues? No.

Checklist:

victorges commented 6 months ago

🥳

Screenshot 2024-03-15 at 17 04 22
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00000%. Comparing base (3966c9d) to head (bde5baa).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/protocol/pull/639/graphs/tree.svg?width=650&height=150&src=pr&token=HsWqRPsbjD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/protocol/pull/639?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## delta #639 +/- ## ==================================================== + Coverage 99.61861% 100.00000% +0.38139% ==================================================== Files 29 29 Lines 1311 1311 Branches 218 218 ==================================================== + Hits 1306 1311 +5 + Misses 5 0 -5 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/livepeer/protocol/pull/639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/protocol/pull/639?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/protocol/pull/639?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [3966c9d...bde5baa](https://app.codecov.io/gh/livepeer/protocol/pull/639?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). [see 1 file with indirect coverage changes](https://app.codecov.io/gh/livepeer/protocol/pull/639/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)