api: stream: allow name update

livepeer / studio

Livepeer Studio is your home for building, broadcasting, and publishing video on the open internet with the Livepeer Network. Effortlessly manage livestreams, video uploads, API keys, network usage, billing, and more.

https://livepeer.studio

MIT License

79 stars 32 forks source link

api: stream: allow name update #2323

Closed gioelecerati closed 1 month ago

gioelecerati commented 1 month ago

What does this pull request do? Explain your changes. (required)

Allow name as field in PATCH stream api

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
livepeer-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 17, 2024 5:27pm

gioelecerati commented 1 month ago

@victorges do you know why the stream name was immutable till now? There was also a specific test making sure it was immutable (the stream name is immutable) - is a name update going to affect anything?

victorges commented 1 month ago

@gioelecerati oh wow super weird that there's even a test. I have no idea 😅 can't think of anything that would break but now it's better to test it anyway. Maybe on the very beginning it was used for configuring streams on mist (or even wowza lol)

gioelecerati commented 1 month ago

@gioelecerati oh wow super weird that there's even a test. I have no idea 😅 can't think of anything that would break but now it's better to test it anyway. Maybe on the very beginning it was used for configuring streams on mist (or even wowza lol)

Coold :D was added here https://github.com/livepeer/studio/pull/430 and I think it was just added without any specific reason, but let's test throughly either way!

victorges commented 1 month ago

@gioelecerati lol got it. that PR has nothing to do with stream name then, probably just a confusing string i used to test the additionalProperties validation.