search

livepeer / subgraph

This repository contains the code for the Livepeer Protocol subgraph
5 stars 5 forks source link

subgraph: gasUsed for winningTicketRedeemds is the gas limit on the tx and not the actual gas used #27

Open yondonfu opened 4 years ago

yondonfu commented 4 years ago

Describe the bug (required) A clear and concise description of what the bug is.

I entered the following query at https://thegraph.com/explorer/subgraph/livepeer/livepeer:

{
  winningTicketRedeemeds(first :5, orderBy: blockNumber, orderDirection: desc) {
    gasUsed
  }
}

and I noticed that for tx 0xd05bf9676006101c15249494d5a1c83a16d3e8751ae589291d64cdd370b36314 the gasUsed field is 261183, but the gas used shown on the Etherscan page is 257657. 261183 is actually the gas limit of the tx and not the gas used by the tx.

Expected behavior (required) A clear and concise description of what you expected to happen.

The gasUsed field should represent the gas used by a tx and not the gas limit of the tx.

yondonfu commented 3 years ago

Related https://github.com/graphprotocol/graph-ts/issues/80

adamsoffer commented 2 years ago

@0xcadams - According to this update by the graph team, updating graph-cli & graph-ts to their latest versions fixes this issue. Can you confirm?

0xcadams commented 2 years ago

Yeah so the update changed that field name to be gasLimit instead of gasUsed. And then there's the option to have a receipt field to get the gasUsed. We'd need to add a bit more code to get the gasUsed field to be actual gas used and not gas limit

https://github.com/graphprotocol/graph-node/issues/3218#issuecomment-1055741638