search

livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
3 stars 2 forks source link

Pass through dsotage urls #125

Closed red-0ne closed 1 year ago

red-0ne commented 1 year ago

Since IPFS and Arweave urls are now handled by catalyst-api, there is no need to have this logic here and should just pass through the url.

Should close https://github.com/livepeer/studio/issues/1580

codecov[bot] commented 1 year ago

Codecov Report

Merging #125 (f8c0afa) into main (3047363) will increase coverage by 0.10061%. The diff coverage is 0.00000%.

Impacted file tree graph

@@                Coverage Diff                 @@
##               main        #125         +/-   ##
==================================================
+ Coverage   9.90447%   10.00508%   +0.10061%     
==================================================
  Files            14          14                 
  Lines          1989        1969         -20     
==================================================
  Hits            197         197                 
+ Misses         1779        1759         -20     
  Partials         13          13
Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3047363...f8c0afa. Read the comment docs.

Impacted Files Coverage Δ
task/upload.go 0.00000% <0.00000%> (ø)
thomshutt commented 1 year ago

Once this is tested and deployed, is there potentially task-runner config we can clean up (IPFS gateway list etc.) @victorges or is it still used elsewhere?