search

livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
3 stars 2 forks source link

runner: humanize max resolution errors from mediaconvert pipeline #150

Closed emranemran closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #150 (2172abf) into main (af4b3e0) will increase coverage by 0.04338%. The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #150         +/-   ##
===================================================
+ Coverage   11.41597%   11.45935%   +0.04338%     
===================================================
  Files             14          14                 
  Lines           2041        2042          +1     
===================================================
+ Hits             233         234          +1     
  Misses          1791        1791                 
  Partials          17          17
Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (+0.19117%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af4b3e0...2172abf. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 18.18182% <100.00000%> (+0.19117%) :arrow_up:
thomshutt commented 1 year ago

This is a good humanization of the error, but should we be smarter in our code that generates the output profiles? Assuming this big resolution is because we're matching a high-resolution source, we could set maximums there and not match beyond a defined maximum (probably 4K)

emranemran commented 1 year ago

This is a good humanization of the error, but should we be smarter in our code that generates the output profiles? Assuming this big resolution is because we're matching a high-resolution source, we could set maximums there and not match beyond a defined maximum (probably 4K)

Yeah we should. Filed https://github.com/livepeer/catalyst-api/issues/468 to follow up. I'll go ahead and merge this so that we categorize these correctly for now until the Livepeer pipeline is fully in effect.