Closed victorges closed 1 year ago
There is an error when uploading to IPFS on create when passing in the player template
Merging #170 (89919db) into main (66147fb) will not change coverage. The diff coverage is
0.00000%
.:exclamation: Current head 89919db differs from pull request most recent head e38ad08. Consider uploading reports for the commit e38ad08 to get more accurate results
@@ Coverage Diff @@
## main #170 +/- ##
=============================================
Coverage 10.86957% 10.86957%
=============================================
Files 14 14
Lines 2162 2162
=============================================
Hits 235 235
Misses 1910 1910
Partials 17 17
Impacted Files | Coverage Δ | |
---|---|---|
task/export.go | 0.00000% <0.00000%> (ø) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 66147fb...e38ad08. Read the comment docs.
Impacted Files | Coverage Δ | |
---|---|---|
task/export.go | 0.00000% <0.00000%> (ø) |
We had a legacy check on the export task to only allow assets with playback URLs to use player NFT metadata. This was because our very first assets didn't even have an HLS playlist and just provided MP4 URLs.
For new assets creation, the only other place where
saveNFTMetadata
is called, this is not necessary tho, as we will always create an HLS playback URL for the asset, or at least have it playable on the player.This fixes API-36