livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
3 stars 2 forks source link

task: Make 4xx errors from Catalyst unretriable #175

Closed victorges closed 1 year ago

victorges commented 1 year ago

This is to improve our error classification and both not retry as well as not alert from user-input errors on the request to Catalyst (normally bad input URLs).

codecov[bot] commented 1 year ago

Codecov Report

Merging #175 (5cfd3a8) into main (ededb39) will decrease coverage by 0.03300%. The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #175         +/-   ##
===================================================
- Coverage   11.95201%   11.91901%   -0.03300%     
===================================================
  Files             14          14                 
  Lines           2167        2173          +6     
===================================================
  Hits             259         259                 
- Misses          1889        1895          +6     
  Partials          19          19                 
Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <0.00000%> (-4.36107%) :arrow_down:
task/upload.go 6.68103% <0.00000%> (-0.02893%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ededb39...5cfd3a8. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <0.00000%> (-4.36107%) :arrow_down:
task/upload.go 6.68103% <0.00000%> (-0.02893%) :arrow_down: