livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
4 stars 2 forks source link

Don't reject audio-only VOD assets #213

Open thomshutt opened 1 year ago

thomshutt commented 1 year ago

This is now supported in Catalyst API with https://github.com/livepeer/catalyst-api/pull/843

mjh1 commented 1 year ago

This probe call is no longer used by the upload task (https://github.com/livepeer/task-runner/pull/212), however I did notice it's still in use by 'transcode' (not transcode API) and 'import' tasks. @victorges could you remind me are these tasks in use anymore? If not would it be safe to delete them?

victorges commented 1 year ago

@mjh1 Those are the legacy flows for VOD. Import is equivalent to the Upload today, while transcode was a "mutation" of existing assets like to ask for a different profile for the master rendition or something like that. I believe it is not used anywhere, we don't document it nor expose on SDKs at least, and I guess they might even be completely broken by now. You can make sure by looking for tasks of type import or transcode on the DB, but I think it should be mostly safe to delete yeah!