search

livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
4 stars 2 forks source link

Enable thumbs for all studio vod jobs #226

Closed mjh1 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

Merging #226 (fb10e88) into main (e6d9ed4) will increase coverage by 0.03563%. The diff coverage is 0.00000%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/task-runner/pull/226/graphs/tree.svg?width=650&height=150&src=pr&token=YHRF6U902Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## main #226 +/- ## =================================================== + Coverage 17.51269% 17.54832% +0.03563% =================================================== Files 16 16 Lines 1970 1966 -4 =================================================== Hits 345 345 + Misses 1600 1596 -4 Partials 25 25 ``` | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `16.51376% <0.00000%> (+0.10039%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [e6d9ed4...fb10e88](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `16.51376% <0.00000%> (+0.10039%)` | :arrow_up: |
emranemran commented 9 months ago

LGTM, main concern is the ffmpeg calls on every segment which will increase our pod loads.