livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
4 stars 2 forks source link

task: Fix usages of api.AssetSpec.Storage field, now a ptr #238

Closed victorges closed 3 months ago

victorges commented 3 months ago

Sometimes I hate go verbosity

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 16.51270%. Comparing base (3d2a29a) to head (7cef519).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/task-runner/pull/238/graphs/tree.svg?width=650&height=150&src=pr&token=YHRF6U902Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/task-runner/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## main #238 +/- ## =================================================== - Coverage 16.56051% 16.51270% -0.04781% =================================================== Files 16 16 Lines 1727 1732 +5 =================================================== Hits 286 286 - Misses 1416 1421 +5 Partials 25 25 ``` | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/238?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/runner.go](https://app.codecov.io/gh/livepeer/task-runner/pull/238?src=pr&el=tree&filepath=task%2Frunner.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay9ydW5uZXIuZ28=) | `18.23899% <0.00000%> (-0.03832%)` | :arrow_down: | | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/238?src=pr&el=tree&filepath=task%2Fupload.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `15.82734% <0.00000%> (-0.11469%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/task-runner/pull/238?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/task-runner/pull/238?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [3d2a29a...7cef519](https://app.codecov.io/gh/livepeer/task-runner/pull/238?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/238?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/runner.go](https://app.codecov.io/gh/livepeer/task-runner/pull/238?src=pr&el=tree&filepath=task%2Frunner.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay9ydW5uZXIuZ28=) | `18.23899% <0.00000%> (-0.03832%)` | :arrow_down: | | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/238?src=pr&el=tree&filepath=task%2Fupload.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `15.82734% <0.00000%> (-0.11469%)` | :arrow_down: |