livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
4 stars 2 forks source link

clients/catalyst: Allow empty profiles to be sent on upload req #240

Closed victorges closed 3 months ago

victorges commented 3 months ago

In order to allow no transcoding for recordings, we'll need to send an empty profiles array so that only the "copy" profile is used (https://github.com/livepeer/catalyst-api/pull/1261).

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.48478%. Comparing base (526f5be) to head (e565d5c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/task-runner/pull/240/graphs/tree.svg?width=650&height=150&src=pr&token=YHRF6U902Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/task-runner/pull/240?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## main #240 +/- ## =================================================== + Coverage 16.46517% 16.48478% +0.01961% =================================================== Files 16 16 Lines 1737 1741 +4 =================================================== + Hits 286 287 +1 - Misses 1426 1428 +2 - Partials 25 26 +1 ``` | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/240?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [clients/catalyst.go](https://app.codecov.io/gh/livepeer/task-runner/pull/240?src=pr&el=tree&filepath=clients%2Fcatalyst.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y2xpZW50cy9jYXRhbHlzdC5nbw==) | `84.00000% <66.66667%> (-2.11111%)` | :arrow_down: | | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/240?src=pr&el=tree&filepath=task%2Fupload.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `15.79892% <0.00000%> (-0.02842%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/task-runner/pull/240?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/task-runner/pull/240?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [526f5be...e565d5c](https://app.codecov.io/gh/livepeer/task-runner/pull/240?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/240?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [clients/catalyst.go](https://app.codecov.io/gh/livepeer/task-runner/pull/240?src=pr&el=tree&filepath=clients%2Fcatalyst.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-Y2xpZW50cy9jYXRhbHlzdC5nbw==) | `84.00000% <66.66667%> (-2.11111%)` | :arrow_down: | | [task/upload.go](https://app.codecov.io/gh/livepeer/task-runner/pull/240?src=pr&el=tree&filepath=task%2Fupload.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay91cGxvYWQuZ28=) | `15.79892% <0.00000%> (-0.02842%)` | :arrow_down: |