search

livepeer / task-runner

Background service that executes tasks from the Livepeer API. Mainly used for VOD.
MIT License
4 stars 2 forks source link

Add check for nil in ipfs.NFTMetadata to avoid panic #243

Closed leszko closed 1 month ago

leszko commented 1 month ago

Related to panic we encounter in prod.

https://eu-metrics-monitoring.livepeer.live/grafana/goto/BiMG6oXIR?orgId=1

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 16.45642%. Comparing base (69c3cc5) to head (d46cfde).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/livepeer/task-runner/pull/243/graphs/tree.svg?width=650&height=150&src=pr&token=YHRF6U902Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer)](https://app.codecov.io/gh/livepeer/task-runner/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) ```diff @@ Coverage Diff @@ ## main #243 +/- ## =================================================== - Coverage 16.48478% 16.45642% -0.02836% =================================================== Files 16 16 Lines 1741 1744 +3 =================================================== Hits 287 287 - Misses 1428 1431 +3 Partials 26 26 ``` | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/243?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/runner.go](https://app.codecov.io/gh/livepeer/task-runner/pull/243?src=pr&el=tree&filepath=task%2Frunner.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay9ydW5uZXIuZ28=) | `17.93814% <0.00000%> (-0.11165%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/livepeer/task-runner/pull/243?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/livepeer/task-runner/pull/243?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Last update [69c3cc5...d46cfde](https://app.codecov.io/gh/livepeer/task-runner/pull/243?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer). | [Files](https://app.codecov.io/gh/livepeer/task-runner/pull/243?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer) | Coverage Δ | | |---|---|---| | [task/runner.go](https://app.codecov.io/gh/livepeer/task-runner/pull/243?src=pr&el=tree&filepath=task%2Frunner.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livepeer#diff-dGFzay9ydW5uZXIuZ28=) | `17.93814% <0.00000%> (-0.11165%)` | :arrow_down: |