Closed danielgindi closed 9 years ago
These are some important improvements... Are you planning on pulling the request?
Thanks for the pull request @danielgindi! We're in the middle of some refactoring of the LiveSDK for iOS to support cocoapods and clean up what's in the repo. I noticed you have several changes integrated into a single pull request, including: a) download to disk instead of RAM, b) enable setting/restoring sessions, c) delegate-based refresh token storage. It would be helpful for us if you can split these into individual pull requests so we can evaluate each change individually.
Well I actually have no idea how to separate pull requests on GitHub... they are already on different commits
The longer you wait before pulling the request - the more commits are added ;-) I think GitHub can't create separate pull requests
You can only have one pull request per branch. You need to separate the changes into different feature branches and submit a pull request from each branch.
I've separated them - thanks!
Anyone alive here? :-)
There aren't a lot of engineers around right now due to the holidays. We'll get to your pull requests as soon as we can.
I do not know how to build this framework, there's no build script. So someone else will have to do that.