Allow bypassing the plist storage for refreshToken

liveservices / LiveSDK-for-iOS

LiveSDK library for integrating with Live Connect

MIT License

138 stars 84 forks source link

Allow bypassing the plist storage for refreshToken #48

Closed danielgindi closed 9 years ago

danielgindi commented 9 years ago

We need to let the developer choose when to refresh and when and where to save the refreshToken - as an alternative to using the plist storage.

sylverb commented 9 years ago

Thanks for this patch, it should really be merged as it's allowing to :

Save the token in a secured way (keychain)
Share token with app extensions
Handle multiple OneDrive accounts in one application

aclev commented 9 years ago

This is a great change, however there is one major issue. It is now possible to create a LiveConnectClient without a _storage object. If a developer were to accidentally do this, the auto-refreshing logic will no longer work. Is it possible to subclass LiveAuthStorage, and create a new init method for LiveConnectClient (and LiveConnectClientCore) that takes a LiveAuthStorage as a parameter? This way you can make the Storage do whatever you want.

Thanks

aclev commented 9 years ago

As I mentioned before this is a great change but without the modifications I suggested we can't accept the pull request. I am closing the pull request pending further changes.