search

liveview-native / live_view_native

A framework for building native applications with Phoenix LiveView
https://native.live/
MIT License
458 stars 19 forks source link

Corrected import name + Docs typos #142

Closed cohawk closed 3 months ago

cohawk commented 4 months ago

another slight annoyance I came across (that I do not have a good solution for) when pulling these libs from GitHub was the usage of underscores in live_view_native and dashes in liveview-client-swiftui

I know Elixir/Phoenix primarily use underscores, while Apple/SwiftUI use dashes - but that did not stop me from staring at this for 10mins of mix deps.get output before realizing, so others might have similar issue.

{:live_view_native, git: "https://github.com/liveview-native/live-view-native.git", override: true},
{:live_view_native_swiftui, git: "https://github.com/liveview-native/liveview-client-swiftui.git"}
bcardarella commented 3 months ago

@cohawk could you please rebase this against main?

cohawk commented 3 months ago

I’m away from terminal for a bit

with the minimal amount of typos probably easier for @BrooklinJazz to just copy them into a new PR

BrooklinJazz commented 3 months ago

Will do!

BrooklinJazz commented 3 months ago

closing in favor of: https://github.com/liveview-native/live_view_native/pull/174