search

liveview-native / liveview-native-core

Provides core language-agnostic functionality for LiveView Native across platforms
MIT License
146 stars 10 forks source link

Stream event serialization broken with latest Phoenix Live View #192

Closed mobile-bungalow closed 1 month ago

mobile-bungalow commented 1 month ago

Streaming updates no longer parse in the json schema .

Reproduction: 

mix deps.get && mix compile && mix phx.server &
cargo run  --example streaming

This means streaming is broken in the most recent phoenix live view. Potentially we should have a nightly canary CI job which runs integration tests with the latest schemas as exhaustively as possible.

mobile-bungalow commented 1 month ago

with #193 we just need integration tests to prevent future regressions.

mobile-bungalow commented 1 month ago

192 closes this. (Failed CI run here)[https://github.com/mobile-bungalow/liveview-native-core/pull/2] as evidence when backporting this change before #193