search

liveview-native / liveview-native-core

Provides core language-agnostic functionality for LiveView Native across platforms
MIT License
142 stars 9 forks source link

LiveView Native Clients: template comments caused stack trace #95

Open bcardarella opened 5 months ago

bcardarella commented 5 months ago

The following:

<!-- ignore this

<!-- ignore this too -->

While this has two opening comment tags the 2nd one should be ignored as it is technically commented out. The first open comment tag should comment all the way until it reaches the first closing comment tag. This current results in a stack trace:

Screenshot 2024-04-18 at 12 01 47 PM
carson-katri commented 5 months ago

This should be raised in core, which handles all document parsing.

Also, nested comments are not valid in HTML. Should we be allowing that anyways?