livingbio / typed-ffmpeg

Modern Python FFmpeg wrappers offer comprehensive support for complex filters, complete with detailed typing and documentation.
https://livingbio.github.io/typed-ffmpeg/
MIT License
82 stars 2 forks source link

fix #351 use factory method to generate FilterNode #367

Closed lucemia closed 6 months ago

lucemia commented 6 months ago

fix #351, create a factory method

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.17%. Comparing base (0db67f0) to head (298c2ef).

:exclamation: Current head 298c2ef differs from pull request most recent head b3d6dc1. Consider uploading reports for the commit b3d6dc1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #367 +/- ## ========================================== - Coverage 97.59% 97.17% -0.43% ========================================== Files 42 43 +1 Lines 1540 1558 +18 ========================================== + Hits 1503 1514 +11 - Misses 37 44 +7 ``` | [Flag](https://app.codecov.io/gh/livingbio/typed-ffmpeg/pull/367/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livingbio) | Coverage Δ | | |---|---|---| | [3.10](https://app.codecov.io/gh/livingbio/typed-ffmpeg/pull/367/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livingbio) | `97.17% <100.00%> (-0.43%)` | :arrow_down: | | [3.11](https://app.codecov.io/gh/livingbio/typed-ffmpeg/pull/367/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livingbio) | `97.17% <100.00%> (-0.43%)` | :arrow_down: | | [3.12](https://app.codecov.io/gh/livingbio/typed-ffmpeg/pull/367/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livingbio) | `97.17% <100.00%> (-0.43%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=livingbio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.