search

livingsocial / bundler-patch

Update your gems conservatively to deal with vulnerable gems or just get more current.
MIT License
65 stars 3 forks source link

Refactor/new version calculator #28

Open JuanitoFatas opened 8 years ago

JuanitoFatas commented 8 years ago

Hi Chris,

I am getting started with the codebase, and I find it extract to smaller class (1ca92db) can be easier to understand and easier to write tests (in my opinion). But the downsides are the cost of file jumps (for reader) and a new dependency for UpdateSpec (now depends on NewVersionCalculator).

2bbc58d is on your call, I change it so there is no need to call .dup when passing in patched_versions, so the reader won't have to worry: Oh! Something destructive goes on there.

What do you think? :)

chrismo commented 8 years ago

NewVersionCalculator I'm probably good with. I'll soak my brain in it some more later.

chrismo commented 8 years ago

apologies for ignoring this. since bundler 1.13.0.rc.2 is now released, this stuff is getting more of my attention, so i might get back to this soon. i'm happy for your contributions!