search

livingsocial / bundler-patch

Update your gems conservatively to deal with vulnerable gems or just get more current.
MIT License
65 stars 3 forks source link

Init a CONTRIBUTING.md file #32

Closed JuanitoFatas closed 5 years ago

JuanitoFatas commented 8 years ago

This Pull Request adds a CONTRIBUTING.md file to guide others to contribute to this project.

Move some contents from README.md to CONTRIBUTING.md, and elaborate a bit on howto run specs.

Preview updated README.md Preview CONTRIBUTING.md

chrismo commented 8 years ago

The Development status text I'd still to have in the README.

The BUNDLER_TEST_VERSION was a recent addition to get CI setup, but it does cause the one test to break, which I only added to help troubleshoot CI, so I do need to get that cleaned up. I'm not sure if specifying it matters when running individual tests locally ... ? May require the ci rake task? But I'm just typing from memory after a few days off work.

JuanitoFatas commented 8 years ago

The BUNDLER_TEST_VERSION was a recent addition to get CI setup, but it does cause the one test to break, which I only added to help troubleshoot CI, so I do need to get that cleaned up.

Do you want me to remove that spec? :)

chrismo commented 8 years ago

no, i think i like the spec because it's a crucial part of the CI process, and only the CI process is going to regularly double-check the various combinations i'd like to support.

that said, we still need to make this simple for local development.