search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Add logo to README #14

Closed ghost closed 5 years ago

ghost commented 5 years ago

Uses a hack to add the logo to the center of the README.

Check out https://stackoverflow.com/questions/12090472/github-readme-md-center-image for more information on the hack.

liviuschera commented 5 years ago

Thanks buddy for your contribution and for sharing the knowledge. I like your ideas so I'll pull in all your requests.

Cheers! 🙂

liviuschera commented 5 years ago

Apparently vsce doesn't like relative paths in <img> tags. When I'm trying to publish the theme I get: Error: Images in README.md must come from an HTTPS source: ./images/logo.png

After a quick search I found this.

After replacing the relative path with the absolute one vsce stopped complaining, but this time the VS Marketplace is not displaying it at all.

Please let me now if you have any ideas on how to fix this one.

ghost commented 5 years ago

@liviuschera Looks fine to me.

The Noctis Extension

liviuschera commented 5 years ago

All good mate. I fixed it in the last release. Thanks for your feedback buddy. 🙏