Improve Color Theme of Terminal

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors

https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis

MIT License

554 stars 67 forks source link

Improve Color Theme of Terminal #21

Closed innerlee closed 5 years ago

innerlee commented 5 years ago

I love this theme. However the color matching for terminal is a little less harmonic. Above is a comparison: left noctis, right nord. Nord's terminal is better imho.

liviuschera commented 5 years ago

Hi there! Thanks for your feedback. Would you please elaborate as I'm not seeing the issue you want to point out?

Cheers!

innerlee commented 5 years ago

Hi, this color is too bright.

liviuschera commented 5 years ago

Good catch, mate! It is, indeed, brighter than intended (65% luminosity instead of 60%). Is there anything else?

innerlee commented 5 years ago

Thanks! just personal feelings. Below, the three colors are also brighter than my expectation

innerlee commented 5 years ago

For comparison, the following is the nord theme

liviuschera commented 5 years ago

Done! Please give it a go an let me know how do you feel about it.

innerlee commented 5 years ago

It's definitely better now.

The background color with gray font is barely visible in the following places. Compare them with the datetime in the bottom-right corner. The datetime is clearer and less causes eye strains.

liviuschera commented 5 years ago

Just to be clear, the screenshots are from Noctis Minumus?

innerlee commented 5 years ago

yea they are

liviuschera commented 5 years ago

I tweaked it a bit more. Give it a spin and let me know if it's better for you.

innerlee commented 5 years ago

Cool! looks good. See below.