search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
564 stars 73 forks source link

Fix filenames and beautify #22

Closed MatteoCampinoti94 closed 5 years ago

MatteoCampinoti94 commented 5 years ago

The Noctis theme filename was Noctis.json instead of noctis.json, which broke the theme.

Furthermore I applied an automated beautifier to all theme/*.json files to make them easier to read and edit.

liviuschera commented 5 years ago

Hi Matteo,

Thanks for pointing out this issues.

For some unidentified reason the theme generator likes to capitalize noctis.json file. It's not a consistent behavior so I couldn't find a way to replicate it so when this happens I have to do it manually.

After implementing the theme generator I thought that there was no need for the generated themes in /themes folder to be 'pretty'. All the theme workbench colors are sitting in the /src/workbench/*.mjs files and the syntax colors in /src/syntax.mjs file. If you want to make any change you'll have to make in those files and then to run npm run build command to generate the themes.

For more background info have a look at "How to contribute" section in the README.md file.

Having said that you'll notice that in v8.9.0 I modified the code in buildTheme.mjs so that from now on it will pretty-print all the themes with 3 indent spaces. Also in an attempt to fix the naming issue all the themes in the /themes are deleted before generating new ones.

I hope this will fix both issues. Let me know what you think about it.

Cheers!

MatteoCampinoti94 commented 5 years ago

Imagined they were generated, but didn't notice the script, my bad sorry ^^'

I'll try and work on the script itself then, see if I can trace the filename issue.

Closing this pull request.