search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Prevent theme-removal crashes and remove Noctis.json #23

Closed MatteoCampinoti94 closed 5 years ago

MatteoCampinoti94 commented 5 years ago

I edited makeThemePath.mjs and added an if to make sure the theme file exists before removing it, otherwise it would cause a crash whenever a new theme was generated without a file present already. I couldn't find any reason why it would generate a file with a different case though, very weird.

Also removed the remaining Noctis.json.

Could also easily modify the script to delete everything inside the themes folder, that way there would be no leftovers if a theme name is changed.

MatteoCampinoti94 commented 5 years ago

Also added AsciiDoc to the README, had forgotten to do that back when I generalized the markup keywords in pull #6.

That pull actually allows Noctis to highlight any markup language, provided their extension uses the correct keywords.

liviuschera commented 5 years ago

Looks good. I'll merge it and release it. I hope it will fix the upper case bug. Cheers mate!