search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Italics in syntax highlighting #25

Closed chiangs closed 5 years ago

chiangs commented 5 years ago

I would really love more support for italics in the syntax highlighting similar to Lucy, where const, import, using, and params or types in params (typescript) are italicized. I have used Lucy for a bit, but I prefer Noctis Minimus.

Perhaps replace the bold parts with italicized...anyway, here's hoping for some more italics 🍻

Thanks!

liviuschera commented 5 years ago

Thanks for your suggestions mate. Let me look into it and I'll get back to you.

liviuschera commented 5 years ago

Done! Import/export statements and datatype annotations are italicized. Hope you'll like it.

Cheers!

chiangs commented 5 years ago

awesome! a little nit-picky, but perhaps consider extending the syntax highlighting to non primitive types?

Example of current, whereas visually I personally would expect all types to be formatted the same.

code

liviuschera commented 5 years ago

Thanks for your feedback mate, I'm glad that you like it.

Although for the highlighting of the type annotations I'm already using a distinct colour I decided (as per your suggestion, which I really like 😊) to italicise only the primitive data types to have a nice visual distinction between primitive types and non-primitive ones. In upcoming releases I will implement this change across all the languages that have primitive type annotations.

Cheers!

chiangs commented 5 years ago

Cool, I can also see the appeal of having it differentiated, cheers for being so quick to implement changes! 🍻 Thanks!