search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Noctis overrides Markdown diff code block styling #31

Closed zachvalenta closed 4 years ago

zachvalenta commented 4 years ago

Noctis seems like it might be overriding VS Code's default syntax highlight for Markdown diff code blocks.

Example screenshots and a bit more explanation here.

zachvalenta commented 4 years ago

Also, keep up the good work! I've been using Noctis for almost a year now and really liking it.

liviuschera commented 4 years ago

Hi mate! Thanks for the feedback. I really appreciate it. 😊

In regards to the issue you raised, as you can see in the attached screenshots, everything works just fine for me.

src dif

prev diff

The only thing that comes to mind is that maybe you modified the indentation as apparently vscode is sensitive to it. I have noticed that if I add a space in front of + or - the diff highlight will not work anymore in the preview.

Please let me know if playing with indentation helped.

Cheers!

zachvalenta commented 4 years ago

Just to clarify: I'm talking about the syntax highlight in the normal editor mode, not the preview.

I can see the diff highlight in the preview, but we should also see it in the editor as well, like this https://github.com/microsoft/vscode/issues/83683#issuecomment-548159182. Right now I can only see the diff highlighting in the editor w/ Noctis disabled.

liviuschera commented 4 years ago

Done. Added syntax highlighting for the inserted and deleted diff code.

Please let me know if i's OK for you.

zachvalenta commented 4 years ago

Really good stuff, and much appreciated :) 👍🏼