search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Fix ruby def class syntax highlight #33

Closed kiendang closed 4 years ago

kiendang commented 4 years ago

This makes Ruby's class and def syntax highlighting match their end.

Before

Screen Shot 2019-11-12 at 2 34 48 PM

After

Screen Shot 2019-11-12 at 2 50 42 PM

Btw thanks for making these excellent themes!

liviuschera commented 4 years ago

Hi there!

I think you are right. It's important to be consistent, so keywords like class, def should match their end keyword. For now it's only possible to target class and def but impossible to target highlight end. Until such time comes we'll highlight all this keywords with the same color.

Thanks for your contribution mate.

Cheers!

kiendang commented 4 years ago

For now it's only possible to target class and def but impossible to target highlight end.

This might be possible soon textmate/ruby.tmbundle#131.

liviuschera commented 4 years ago

I would love to see it implemented.