search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Added solarized noctis theme: themes/solarized.json #35

Closed CrHasher closed 4 years ago

CrHasher commented 4 years ago

Given that the original noctis theme is pretty close to solarized (a lot of green is used), I used it to make a truly solarized based version. I think the result is a very nice theme, to me it looks better than any solarized theme currently available.

liviuschera commented 4 years ago

Hi mate,

Thanks for the interest that you took in the Noctis theme and for the effort of coming up with a new theme.

While the theme that you submitted has a lot in common with Solarized theme, I think that, in my opinion, it's quite different from the Noctis themes. As you may have noticed all dark themes have in common the same syntax colours and font styling. Same goes with the light themes versions. They share the same hue with the colours from the dark themes. I just adjusted the saturation and lightness. In your theme you mostly used Solarized colours and styling is different again from the Noctis theme.

That's why I'm using the theme generator included in the repo.

Having said that I trust you'll understand why I prefer to stick to the Noctis theme design concepts.

Cheers!

CrHasher commented 4 years ago

I agree that the new theme is totally different than all other noctis themes. Is it ok with you if I use your theme as base for a new one that has only this solarized version (will call it something else than noctis, ex. Solarized+)? If not I will just use noctis with my custom theme given there is no good solarized version on the market place.

Thanks!

liviuschera commented 4 years ago

Sure thing buddy! Please feel free to reuse whatever you find useful/of interest in Noctis theme.

Happy hacking!