liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Italic for `type` in `import type` #38

Closed JacksonKearl closed 4 years ago

JacksonKearl commented 4 years ago

Issue Type: Bug

Currently there are keyword.control.import { "fontStyle": "italic" } and keyword.control.from { "fontStyle": "italic" }, it would be nice to also have keyword.control.type { "fontStyle": "italic" } for the new import type syntax in TS3.8. I could configure in "editor.tokenColorCustomizations", but that's not ideal as I'd need a seperate entry for each variant.

I'm on the VS Code team and I love the theme btw!

Extension version: 10.24.0 VS Code version: Code - Insiders 1.42.0-insider (33c79d5ad447956814a2a3658029dffb9e28bae6, 2020-01-15T08:53:57.100Z) OS version: Darwin x64 18.7.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled| |Load (avg)|1, 2, 2| |Memory (System)|32.00GB (6.94GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
liviuschera commented 4 years ago

Apparently VS Code Typescript grammar is not yet updated so it cannot pick up keyword.control.type token. Any advice regarding this issue?

Thanks for the feedback mate.

JacksonKearl commented 4 years ago

If you go on the latest Insiders and use TS 3.8.0-beta, you should be able to see them:

image

Alternatively, you could just apply it for meta.import, as that seems to be the intent?

liviuschera commented 4 years ago

Done. Happy hacking mate!