search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
564 stars 73 forks source link

Cannot see different green highlight in lux theme #41

Closed Aspire1Inspire2 closed 4 years ago

Aspire1Inspire2 commented 4 years ago

image

I think the green color contrast should be increased a little bit?

liviuschera commented 4 years ago

Will you please describe how can I reproduce this issue?

Aspire1Inspire2 commented 4 years ago

  1. In VS Code, apply the Lux theme from noctis.

  2. Use your preference diff tool or git tool etc. to compare two files/commits, etc.

  3. The VS code will show difference. Red is removed. Green is added. image Figure "remov" should be marked as darker red. "add" should be marked as darker green.

  4. The darker red is the characters that are removed. Correspondingly, the darker green is the characters that are being added.

In the current Lux theme the contrast of light green and darker green is hard to tell.

liviuschera commented 4 years ago

Thanks mate, brilliant walk-through!

It should be fixed now. Let me know if it's what you're after.

Cheers!