search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
547 stars 66 forks source link

Current extensionKind definition is too restrictive #54

Closed bamurtaugh closed 3 years ago

bamurtaugh commented 3 years ago

Hi! I'm from the VS Code team and have tested whether Noctis can run in the different extension host setups VS Code currently supports. I've found that the current definition of extensionKind for your extension is too restrictive.

The extension has the extensionKind set to ["ui"]: https://github.com/liviuschera/noctis/blob/master/package.json#L11.

This defines that the extension can only run in the VS Code desktop extension host. However, this extension can also run on the workspace extension host (which is used for remote scenarios).

Thus, the best practice would be to change the extensionKind to ["ui", "workspace"].

We have a way to customize the extensionKind from an extension in the VS Code core. Given the popularity of your extension I will do this in the meantime.

Please let me know if you have any questions - I'm happy to help clarify anything. Thank you!

liviuschera commented 3 years ago

Hey there! Thanks for reaching out.

Should I modify extensionKind to ["ui", "workspace"]?

Cheers!

bamurtaugh commented 3 years ago

Yes, we'd recommend modifying to ["ui", "workspace"].

There's more information in the section here.

Updating to "extensionKind": ["ui", "workspace"] indicates the extension prefers to run as a UI extension, but does not have any hard requirements on local assets, devices, or capabilities. When using VS Code, the extension will run in VS Code's local extension host if it exists locally, otherwise will run in VS Code's workspace extension host if it exists there. This will also allow your extension to work in the Codespaces browser-based editor (it will run in the remote extension host always when in the browser as no local extension host is available there).

Please let me know if you have any other questions!

liviuschera commented 3 years ago

Sure, no worries.

I've pushed the change and it should be up and running.

Hope it'll fix it.

Cheers!

bamurtaugh commented 3 years ago

Fantastic, thank you for the quick response! 🚀 I'll close out this issue.

Russ716 commented 1 year ago

Hallo! I've got the Cartograph font, because I want the shifting "cursive" semantic formatting as well as these fantastic colors (#TeamAzure!). Unfortunately, I've hit a roadblock. Any chance you can help a new developer out?