liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
547 stars 66 forks source link

The color used for markdown fenced blocks is too dim #63

Closed memeplex closed 9 months ago

memeplex commented 2 years ago

Fenced blocks have many roles in markdown:

  1. verbatim text
  2. code blocks
  3. a generalization of the above in pandoc
  4. a translation of reStructuredText roles in MyST markdown
  5. probably many others

Most Noctis themes treat these blocks almost as comments, in that they are shown in a dimmed down fashion, except when a language is specified (then the syntax highlighting for the language is used, of course). But there is no reason to assume that these blocks are less important than other contents or shouldn't divert attention as much as other contents. This assumption is unsafe even for the vanilla verbatim block.

I think that deemphasizing these blocks is an undesirable quirk of the Noctis themes.

image

liviuschera commented 9 months ago

Hi, this should have been fixed. Please let me know if that's the case.

memeplex commented 9 months ago

It's indeed the case. Thanks!