search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
547 stars 66 forks source link

Support for Markdown strikethrough #69

Closed h-h-h-h closed 9 months ago

h-h-h-h commented 2 years ago

I don't understand the relationship between between VS Code and this extension. But VS Code just added support for rendering ~~strikethrough text~~ in Markdown files differently in the editor. However, with your theme "Noctis Bordo", it currently isn't rendered any different.

Since your read-me lists Markdown as a supported language, is there anything you can do about that, so that strikethrough text is rendered differently -- I'd imagine with strikethrough effect?

liviuschera commented 9 months ago

Hi, this should have been fixed. Please let me know if that's the case.

h-h-h-h commented 9 months ago

The whole ~~strikethrough text~~ now has a strikethrough effect. However, the rendering differs from *italic* and **bold** text. For italic and bold, the asterisks making the text italic or bold are also italic or bold, respectively. But they're also gray! So, ~~ to the left and to the right should follow that pattern and be gray.

But since strikethrough interferes with the text, I think it would be best to omit the strikethrough effect for ~~. Without strikethrough effect, it's like a continuation of the strikethrough, anyway.

The strikethrough line is also a bit thick. Is there a way to make it thinner? You should be able to quite easily read the text, while still quickly and intuitively understanding that there's strikethrough markup. If it's impossible, it's okay.

liviuschera commented 9 months ago

I grayed out tilde character and removed "Cinnabar" color from the strike-through text. I think this should make it more readable. There is no way, as far as I know, to fiddle with the strike-through line, so I'll leave it as is.

h-h-h-h commented 9 months ago

Wouldn't it be more useful, if you could see more of the tilde characters by not striking them through? One may not be able to identify them as tilde characters. I guess you can see perhaps 30 to 40% of them.

Visual Studio Code

Or is that also not possible for some odd reason?

liviuschera commented 9 months ago

As far as I know the line has to go through both tilde characters and text. I could disable it all together but I prefer it enabled.

h-h-h-h commented 9 months ago

Okay. Then let's close this. Thank you!