search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
554 stars 67 forks source link

Use general keywords for markup.underline.link, add markup.link, update package version #7

Closed MatteoCampinoti94 closed 5 years ago

MatteoCampinoti94 commented 5 years ago

Just a little fix to my previous commits, had forgotten to remove the .markdown suffix from markup.underline.link and markup.underline.link.image.

I've also added markup.link, under string.other.link. Some markup languages parse email addresses even when they are used inline without any aprtcular punctuation. In that case a more generalized keyword is often used. For example in asciidoc it's usually markup.link.email.asciidoc. Most links use markup.underline.link or meta.link, so this new scope will cover those few cases that would otherwise go unstyled.

Also modified the package version in package.json to match the version on vscode (4.13.0), since it was still 4.12.0.

liviuschera commented 5 years ago

I looks good. I'll push it to the marketplace right away.

Thanks for this buddy!

MatteoCampinoti94 commented 5 years ago

You're welcome ^^