search

liviuschera / noctis

Noctis is a collection of light & dark themes with a well balanced blend of warm and cold colors
https://marketplace.visualstudio.com/items?itemName=liviuschera.noctis
MIT License
547 stars 66 forks source link

Host color-preview images within the repo #75

Closed JatinSanghvi closed 1 year ago

JatinSanghvi commented 1 year ago

At present, the color preview images are not showing up in GitHub Readme file and in Visual Studio Code Marketplace, most probably due to throttling policy set by Placeholder.com (see Rule 1 on https://placeholder.com/rules/). Since GitHub proxies all request to images hosted on external sites through its github-camo servers (see GitHub documentation: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-anonymized-urls), the Placeholder.com site treats request emitting from different user browsers as arriving from single user and throttles them. The PR stores the images as SVG files inside the repo to fix this situation.

liviuschera commented 1 year ago

Hey mate cheers for the your contribution.

JatinSanghvi commented 1 year ago

Thanks, Liviu. If you ever get time, please publish a new version of the extension so that the color previews appear on the Marketplace page here and in the extension information page inside Visual Studio Code editor as well.