search

liwenyip / hugo-easy-gallery

Automagical css image gallery in Hugo using shortcodes, with optional lightbox/carousel gadget using PhotoSwipe and jQuery.
MIT License
573 stars 111 forks source link

Outdated jQuery Version #45

Closed acahir closed 5 years ago

acahir commented 5 years ago

Why are you including such an old version of jQuery (1.12.4) in load-photoswipe.html? Current version is 3.3.1, so that's two major versions behind.

Considering PhotoSwipe doesn't require jQuery, could also just use vanilla js.

liwenyip commented 5 years ago

Hi @acahir

There was probably a reason why I used that version of jQuery but I can't for the life of me remember what that reason was... and I don't want to mess with code that's not broken :-)

I used jQuery instead of vanilla js because I'm not a web developer (I currently work as a construction project manager) and jQuery was easier to grok at the time.

Migrating to vanilla js has been addressed in #27 and will probably happen eventually :-)

Regards, Li-Wen