Fix Date Format of daily stats + some fields not appearing

liwoo / mse-scripts

Some scripts for scraping MSE and formatting MSE Data

2 stars 1 forks source link

Fix Date Format of daily stats + some fields not appearing #5

Open liwoo opened 3 years ago

liwoo commented 3 years ago

Lets use an ISO 8601 Date format (without the time), i.e. 2021-04-23. Also I see the following field are conspicously missing:

market cap
shares
profits

Please note, required fields are everything from MSE Code till the end.

Why are we getting a now date again?

sevenreup commented 3 years ago

The now date was my bad that was supposed the spot where the stand-in date is supposed to be when there is an error in parsing the date. I'll fix that in the PR. I think the best way is to just get the date from the file name as a fallback if getting from the actual file fails. So for that to work I have to extract the filename from the response header.